dragonleo/NSIS
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Warn when the output filename is setup.exe because Windows will unsafely load compatibility shims

Browse source 
git-svn-id: https://svn.code.sf.net/p/nsis/code/NSIS/trunk@6708 212acab6-be3b-0410-9dea-997c60f758d6
This commit is contained in:
anders_k 2016-02-16 14:35:20 +00:00
parent 94edfa7934
commit 0bd3a0d1a1
1 changed files with 9 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

9
Source/build.cpp
View file

@ -2643,6 +2643,15 @@ int CEXEBuild::write_output(void)
tstring full_path = get_full_path(build_output_filename);
notify(MakensisAPI::NOTIFY_OUTPUT, full_path.c_str());
INFO_MSG(_T("\nOutput: \"%") NPRIs _T("\"\n"), full_path.c_str());
const TCHAR *fname = get_file_name(build_output_filename).c_str();
// Warn when special compatibility names are used. See also: http://github.com/wixtoolset/wix4/commit/3f4341b8ac4d13dffb1d6ba773d48ccc0ab07cf8
if (!lstrcmpi(fname, _T("setup.exe")))
{
const bool orgdispwarn = display_warnings;
display_warnings = false; // Don't display warning inline in the middle of our statistics output.
warning(_T("Insecure filename \"%") NPRIs _T("\", Windows will unsafely load compatibility shims into the process."), fname);
display_warnings = orgdispwarn;
}
}
FILE *fp = FOPEN(build_output_filename,("w+b"));