dragonleo/NSIS
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Fixed a buffer overrun that was causing makensisw.exe to crash - I *think* this is the cause of the elusive crash that's been around for about a week now.

Browse source 
git-svn-id: https://svn.code.sf.net/p/nsis/code/NSIS/trunk@897 212acab6-be3b-0410-9dea-997c60f758d6
This commit is contained in:
sunjammerx 2002-09-03 23:23:15 +00:00
parent b000b54619
commit 12f3bc0af7
1 changed files with 6 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

7
Contrib/Makensisw/utils.cpp
View file

@ -32,7 +32,12 @@ void SetTitle(HWND hwnd,char *substr) {
}
void SetBranding(HWND hwnd) {
char title[16];
// buffer overrun occured here, consider changing to a _snprintf style
// function (Rainwater this is your call, I don't want to introduce use of
// a new string function into your code)... if the buffer is overwritten
// it trashes the function post code. For now I've just increased the size
// of the title buffer -- Sunjammer 04 September 2002.
char title[128];
wsprintf(title,"MakeNSISW %s",NSISW_VERSION);
SetDlgItemText(hwnd, IDC_VERSION, title);
}