dragonleo/NSIS
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

fixed bug #2318670 - New System plug-in never unloads

Browse source 
ebp was never restored from the stack and so edi, esi, ebx and ebp were corrupted when CallProc returned

git-svn-id: https://svn.code.sf.net/p/nsis/code/NSIS/trunk@5785 212acab6-be3b-0410-9dea-997c60f758d6
This commit is contained in:
kichik 2008-11-21 09:57:23 +00:00
parent 0f01464e40
commit 4425d93e75
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Contrib/System/Source/Call.S
View file

@ -343,7 +343,6 @@ FUNC_DECL _CallProc
push dword ptr [ebp+8] push dword ptr [ebp+8]
call _GetGenStackOption call _GetGenStackOption
cmp eax,0 cmp eax,0
;# Remove ebp from stack, no need to generate stack
pop eax pop eax
jne stack_expand_done jne stack_expand_done
@ -658,6 +657,7 @@ handling_error_option_done:
;# Return ;# Return
mov eax,dword ptr [ebp+8] mov eax,dword ptr [ebp+8]
;# Restore registers ;# Restore registers
pop ebp
pop esi pop esi
pop edi pop edi
pop ebx pop ebx