From 7093dc3b2d57e01235a75a9afb156af92cca312e Mon Sep 17 00:00:00 2001 From: kichik Date: Tue, 5 Aug 2003 15:30:31 +0000 Subject: [PATCH] No need to read STATE twice git-svn-id: https://svn.code.sf.net/p/nsis/code/NSIS/trunk@2789 212acab6-be3b-0410-9dea-997c60f758d6 --- Contrib/InstallOptions/InstallerOptions.cpp | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/Contrib/InstallOptions/InstallerOptions.cpp b/Contrib/InstallOptions/InstallerOptions.cpp index f207115f..aac2948b 100644 --- a/Contrib/InstallOptions/InstallerOptions.cpp +++ b/Contrib/InstallOptions/InstallerOptions.cpp @@ -543,11 +543,9 @@ int ReadSettings(void) { ConvertNewLines(pFields[nIdx].pszText); } - // pszState cannot be NULL (?) + // pszState must not be NULL! myGetProfileString(szField, "STATE"); - pFields[nIdx].pszState = myGetProfileStringDup(szField, "STATE"); - if (!pFields[nIdx].pszState) - pFields[nIdx].pszState = STRDUP(szResult); + pFields[nIdx].pszState = strdup(szResult); pFields[nIdx].pszRoot = myGetProfileStringDup(szField, "ROOT");