dragonleo/NSIS
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Fixed possible buffer overflow bug in unused WinWStrDupFromChar function (Patch #271)

Browse source 
git-svn-id: https://svn.code.sf.net/p/nsis/code/NSIS/trunk@6781 212acab6-be3b-0410-9dea-997c60f758d6
This commit is contained in:
anders_k 2016-08-21 12:00:00 +00:00
parent 3b8afc2e89
commit 765d245758
2 changed files with 11 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Docs/src/history.but
View file

@ -1,5 +1,15 @@
\A{history} Changelog and Release Notes \A{history} Changelog and Release Notes
\H{v3.01} 3.01
Released on ? ?th, 201?
\S1{v3.01-cl} Changelog
\S2{} Minor Changes
\b Fixed buffer size bug in winchar.cpp (\W{http://sf.net/p/nsis/patches/271}{patch #271})
\H{v3.0} 3.0 \H{v3.0} 3.0
Released on July 24th, 2016 Released on July 24th, 2016

2
Source/winchar.cpp
View file

@ -46,7 +46,7 @@ int WinWStrNICmpASCII(const WINWCHAR *a, const char *b, size_t n)
WINWCHAR* WinWStrDupFromChar(const char *s, unsigned int cp) WINWCHAR* WinWStrDupFromChar(const char *s, unsigned int cp)
{ {
int cch = MultiByteToWideChar(cp, 0, s, -1, 0, 0); int cch = MultiByteToWideChar(cp, 0, s, -1, 0, 0);
wchar_t *p = (wchar_t*) malloc(cch); wchar_t *p = (wchar_t*) malloc(cch * sizeof(wchar_t));
if (p) if (p)
{ {
MultiByteToWideChar(cp, 0, s, -1, p, cch); MultiByteToWideChar(cp, 0, s, -1, p, cch);