dragonleo/NSIS
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

fixed bug #1403601 - System plug-in heap corruption

Browse source 
git-svn-id: https://svn.code.sf.net/p/nsis/code/NSIS/trunk@4473 212acab6-be3b-0410-9dea-997c60f758d6
This commit is contained in:
kichik 2006-01-13 14:31:28 +00:00
parent de5d36f953
commit 779b1ce1c1
1 changed files with 1 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Contrib/System/Source/System.c
View file

@ -700,7 +700,7 @@ void ParamAllocate(SystemProc *proc)
for (i = 0; i <= proc->ParamCount; i++) for (i = 0; i <= proc->ParamCount; i++)
if (((HANDLE) proc->Params[i].Value == NULL) && (proc->Params[i].Option == -1)) if (((HANDLE) proc->Params[i].Value == NULL) && (proc->Params[i].Option == -1))
{ {
proc->Params[i].Value = (int) GlobalAlloc(GPTR, ParamSizeByType[proc->Params[i].Type]); proc->Params[i].Value = (int) GlobalAlloc(GPTR, 4*ParamSizeByType[proc->Params[i].Type]);
} }
} }
@ -794,10 +794,7 @@ void ParamsDeAllocate(SystemProc *proc)
for (i = proc->ParamCount; i >= 0; i--) for (i = proc->ParamCount; i >= 0; i--)
if (((HANDLE) proc->Params[i].Value != NULL) && (proc->Params[i].Option == -1)) if (((HANDLE) proc->Params[i].Value != NULL) && (proc->Params[i].Option == -1))
{ {
#ifndef _DEBUG
// I see no point for error debug version gives here
GlobalFree((HANDLE) (proc->Params[i].Value)); GlobalFree((HANDLE) (proc->Params[i].Value));
#endif
proc->Params[i].Value = (int) NULL; proc->Params[i].Value = (int) NULL;
} }
} }