dragonleo/NSIS
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

popstringn takes a character count, not a byte size as the max length!

Browse source 
git-svn-id: https://svn.code.sf.net/p/nsis/code/NSIS/trunk@6732 212acab6-be3b-0410-9dea-997c60f758d6
This commit is contained in:
anders_k 2016-04-01 20:17:20 +00:00
parent 8ea946bbf0
commit 7a958101d8
1 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Contrib/nsDialogs/browse.c
View file

@ -104,13 +104,13 @@ void __declspec(dllexport) SelectFileDialog(HWND hwndParent, int string_size, TC
ofn.hwndOwner = hwndParent; ofn.hwndOwner = hwndParent;
ofn.lpstrFilter = filter; ofn.lpstrFilter = filter;
ofn.lpstrFile = path; ofn.lpstrFile = path;
ofn.nMaxFile = sizeof(path); ofn.nMaxFile = COUNTOF(path);
//ofn.Flags = pField->nFlags & (OFN_OVERWRITEPROMPT | OFN_HIDEREADONLY | OFN_PATHMUSTEXIST | OFN_FILEMUSTEXIST | OFN_CREATEPROMPT | OFN_EXPLORER); //ofn.Flags = pField->nFlags & (OFN_OVERWRITEPROMPT | OFN_HIDEREADONLY | OFN_PATHMUSTEXIST | OFN_FILEMUSTEXIST | OFN_CREATEPROMPT | OFN_EXPLORER);
ofn.Flags = OFN_CREATEPROMPT | OFN_EXPLORER; ofn.Flags = OFN_CREATEPROMPT | OFN_EXPLORER;
popstringn(type, sizeof(type)); popstringn(type, COUNTOF(type));
popstringn(path, sizeof(path)); popstringn(path, COUNTOF(path));
popstringn(filter, sizeof(filter)); popstringn(filter, COUNTOF(filter));
save = !lstrcmpi(type, _T("save")); save = !lstrcmpi(type, _T("save"));
@ -148,7 +148,7 @@ void __declspec(dllexport) SelectFileDialog(HWND hwndParent, int string_size, TC
*p = 0; *p = 0;
} }
GetCurrentDirectory(sizeof(currentDirectory), currentDirectory); // save working dir GetCurrentDirectory(COUNTOF(currentDirectory), currentDirectory); // save working dir
if ((save ? GetSaveFileName(&ofn) : GetOpenFileName(&ofn))) if ((save ? GetSaveFileName(&ofn) : GetOpenFileName(&ofn)))
{ {