- Fixed uninstaller not showing anything when installer is silent

- Improved CResourceEditor - should be more tolerant now
- Removed legacy code from InstallOptions and StartMenu


git-svn-id: https://svn.code.sf.net/p/nsis/code/NSIS/trunk@2882 212acab6-be3b-0410-9dea-997c60f758d6

Source/build.cpp

@@ -1818,6 +1818,7 @@ again:
         warning("%sage instfiles not used, no sections will be executed!", uninstall_mode ? "Uninstall p" : "P");
       }
     }
+  }
 
 #ifdef NSIS_CONFIG_UNINSTALL_SUPPORT
     if (!uninstall_mode) {
@@ -1827,7 +1828,7 @@ again:
     else
       set_uninstall_mode(0);
 #endif//NSIS_CONFIG_UNINSTALL_SUPPORT
-  }
+
 
   SCRIPT_MSG("Done!\n");
 
@@ -2944,8 +2945,9 @@ void CEXEBuild::init_res_editor()
 void CEXEBuild::close_res_editor()
 {
   if (!res_editor) return;
+  unsigned char *header_data_new_edited = res_editor->Save((DWORD&)exeheader_size_new);
   free(header_data_new);
-  header_data_new = res_editor->Save((DWORD&)exeheader_size_new);
+  header_data_new = header_data_new_edited;
   delete res_editor;
   res_editor=0;
 }