From 8dbe4f1203ce0249df22a53041a302754b11850b Mon Sep 17 00:00:00 2001 From: kichik Date: Fri, 30 Jan 2004 20:37:43 +0000 Subject: [PATCH] fixed a bug that was present since at least 1.3, which caused IO to read heap memory beyond pszListItems and possibly to crash git-svn-id: https://svn.code.sf.net/p/nsis/code/NSIS/trunk@3435 212acab6-be3b-0410-9dea-997c60f758d6 --- Contrib/InstallOptions/InstallerOptions.cpp | 3 ++- Plugins/InstallOptions.dll | Bin 12288 -> 12288 bytes 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/Contrib/InstallOptions/InstallerOptions.cpp b/Contrib/InstallOptions/InstallerOptions.cpp index ff1fdd08..32563131 100644 --- a/Contrib/InstallOptions/InstallerOptions.cpp +++ b/Contrib/InstallOptions/InstallerOptions.cpp @@ -1151,7 +1151,8 @@ int WINAPI createCfgDlg() do { pszEnd++; } while (*pszEnd == '|'); pszStart = pszEnd; } - pszEnd++; + else + pszEnd++; } FREE(pszList); if (pField->pszState) { diff --git a/Plugins/InstallOptions.dll b/Plugins/InstallOptions.dll index e29e34cc353cbb1fb8f28bb0407bda4b25ad78bf..d5f1575c81af12f4cb04cda59176d91f6b0f12f3 100644 GIT binary patch delta 2190 zcmdT_|8G;*6@NFp1P7eFm*5vCP6Fgh6H}lI^}R1{6OR-ex6o3oARM-_E$df{GKxCC zESm^(Yg@%NNlS0nbyYWDX;muGF)fuSf-%#gB}`}{9okR_Ra#}$3tw6)MbxmAyU%^2 zzx5y3vp&9`bMEJ!d)~Rn*U7$Q-wWsF%sJuP^RIeRwCDOi$;{{kX)mgXwki61s*>8# ztSX5Taoc^oMqSz(hBs!P5JLO_lOoZq3Zo0YuBiPRIHe;hj4*#fW#k;+uQuLsUdD0B zI4%;i+H>J%Pp)kIaYaAA{V_$4t3*+T)O<`NP6UN9$-hwdkuLsX@so8yEJQp{Z#)al zMmu}ciSLOCBgpGZddMW-Uh-Qq#kIL!?-azTlWxIYN90(Xh84Y67@a&c_ukrXn2Y-% zkn?-zh6v>s=5`YQsL$0%5H3_&z5Ig;Makr|5s#Lh#O8nA)uregdhMfd$B$v@#%zSz zK_mp{B!8x~gM|6<(pGYWe_Gl=e#Kq$>S`%c3W$!egg=!pirS~HLmkaVux)sB<-GNT zY~s()&n%JE8`_~1_1YhODMW8{iwFqO@5*+&d+`Q~M#9 zQfpz*36{7=7zG|GySpsz=qX98%rTp%%g%M4hUcz9ckZf1GuN!P)Sxb`5>dPv=LkL^ zc>?7Z#hc*SqTr(owo7`9GyIkE#pEnMQvOGh=UcT-a+1HL^^kEstF@2>Z_*znr+HR? zfF$`p^u_wSPEuO>r#N%G!7*M^(Ly%!zmKn6L`?=)XqoSTqu?a|1^QxowG(KbwtJOB+}d!f zL&~-1+dy&;x-+M=^liMgYE|G{s8Ztgc@mYrMjm&ie&}0-EaN}5eLsGkg%8Fu|K~I2|EBPtYh|< zu$<#R9(;_S@-Fn>`gzCfHoSQtf2pTb-u5<0mt%Q^?F@4MB?{%Etk!072DIip=Jqs z<^CGq^4BkZotyn@haQv}4?FY^lBOK`j-&(p#hS)-8>ORPwbwbL+wOKo-3~dU%Vro; zJ3Vu(Qqdn4Mm2JTS#-ZhME0%LOCS`gJR?A>t%j5j-zGl+L3%<3a zjjygf%C<2@ISIT2{0?{y*a>_H$fq)(D1P9^or)5{*aLjTSJZjUPOv1r^64`bWdIlk zdVp1ce7Y!X;2~feKq9xdV}w;^F~_0d_Xxci-4Db4}re|$AGQC4qzDA2ON|( zwDNIdlNqGB*yK0so>}pK{}!V^UwF4F|H%2_#)eYXq9{)TVYy_0u*QqO0i!x{3aX{)GOFK24vad+2NQO?rqPrhlUE(+PT>UZFQ> z8C$?=nV+?>Ap158vj^CB*+cBdY=EWMFnfi)#s1A^*jLPDYNpq$Gn>o~^B!}pxxw6Q tKHO+NYYv$&n|sXz<{|T_`8V^ddBObDykcHA-R-sQ4ejC4C+_$q`7hm}{VM4uPF>`%s9?o(i;D46(QMtF5(a~m$CW#Lt!F495+tDoH&W4kLDt>5kx{T ze#D+BZKGj!sulm^-U z^6YA}dLsj52?Bk}c|6+31DyBUa$WW~PT(`WT@KXrYpmTKQhTB6g)A2{*9i)j%^-&; zc;AIRn@@^&ExbQyR2MiO=~~3n1pAf!JNM0iawDP&BV9w$q>VeTLtiN7&Vsd6TN$*1 zB{y>CB5SYMQ1O_>mua#?S0-7e;zH;+Eb9mD`c+NN-q6;i2PLi*^P&*$5%OMBPNMw0 zC7&?Nhd zv`RW;B_(E_#GT^=ds%T+Bl^N$<=S$tn2^JJ5w&ef%p8NF6H__@DV-PErpC<{5Hkm% zr-DSxj6pEQZ*ZQ?ik_GZ=Nbdm|xU#6X`yV~b4v**q+WPo61 z`eH_7sp=gS4w$(1p?(!DD6#9+&D6#`%W7H$vo7tkVCDvAbAxl@=+_0L)iw87qoch? z4fI;Nu=Htfx=PDT_N=XK9f=sEv@dC&eJo2=O;nXQui<$Ax_ z_F9p#z#3{-ql+G_b^Blc`18DtpIYME=4qa{#9y0Y))J4J;!|v_w%!{z4gG?#&6@4T zW^0y=4r{gusa@iQ6