Commit graph

1404 commits

Author SHA1 Message Date
kichik
2efd32160b fixed bug #1874297 - Error decompressing data! Corrupted installer?
problem was that decompression ended prematurely. instead of waiting for zlib to return Z_STREAM_END, it checked if no more output was required. this could cause a case where zlib wouldn't read its entire stream. in this particular case, the compressed headers were 0x4001 bytes long and compressed data input buffer size is only 0x4000. instead of waiting for another run of inflate() to read the last byte, which is probably eof, _dodecmop() broke the loop and didn't read that extra byte. since loadHeaders() relays on _dodecomp() to read the entire header so it can calculate where the data block begins, all reads from the data block suddenly became off by one, causing "decompression errors".

git-svn-id: https://svn.code.sf.net/p/nsis/code/NSIS/trunk@5557 212acab6-be3b-0410-9dea-997c60f758d6
2008-02-23 16:28:23 +00:00
kichik
e3b9d1311b update structure comments
git-svn-id: https://svn.code.sf.net/p/nsis/code/NSIS/trunk@5556 212acab6-be3b-0410-9dea-997c60f758d6
2008-02-23 15:04:53 +00:00
kichik
9da157b5ea fixed bug #1900098 - SVN trunk FTBFS on Debian GNU/Linux
git-svn-id: https://svn.code.sf.net/p/nsis/code/NSIS/trunk@5553 212acab6-be3b-0410-9dea-997c60f758d6
2008-02-23 10:20:44 +00:00
kichik
dbd80ca086 fixed bug #1896500 - Exception during compile
git-svn-id: https://svn.code.sf.net/p/nsis/code/NSIS/trunk@5545 212acab6-be3b-0410-9dea-997c60f758d6
2008-02-18 23:24:02 +00:00
kichik
42fa365f04 another typo
git-svn-id: https://svn.code.sf.net/p/nsis/code/NSIS/trunk@5503 212acab6-be3b-0410-9dea-997c60f758d6
2008-01-29 22:43:13 +00:00
kichik
cb0314d2b5 typo
git-svn-id: https://svn.code.sf.net/p/nsis/code/NSIS/trunk@5502 212acab6-be3b-0410-9dea-997c60f758d6
2008-01-29 22:42:53 +00:00
kichik
c08b7206ca zero icon memory to prevent uninitialized memory from getting into the resources
git-svn-id: https://svn.code.sf.net/p/nsis/code/NSIS/trunk@5492 212acab6-be3b-0410-9dea-997c60f758d6
2008-01-26 11:47:01 +00:00
kichik
db25d86b35 RFE #1795426 - User friendly message for corrupt or incomplete installer
git-svn-id: https://svn.code.sf.net/p/nsis/code/NSIS/trunk@5459 212acab6-be3b-0410-9dea-997c60f758d6
2007-12-29 18:05:48 +00:00
kichik
9676bb54cd a empty string can be caused by a path like "\boot.ini", so support that as well
git-svn-id: https://svn.code.sf.net/p/nsis/code/NSIS/trunk@5439 212acab6-be3b-0410-9dea-997c60f758d6
2007-12-22 16:20:06 +00:00
kichik
2675599a31 happy new year!
bug #1855805

git-svn-id: https://svn.code.sf.net/p/nsis/code/NSIS/trunk@5429 212acab6-be3b-0410-9dea-997c60f758d6
2007-12-22 09:41:57 +00:00
kichik
ee4a2444ce verify correct offset in TOK_GETFULLPATHNAME
git-svn-id: https://svn.code.sf.net/p/nsis/code/NSIS/trunk@5425 212acab6-be3b-0410-9dea-997c60f758d6
2007-12-21 22:28:04 +00:00
kichik
8decf5cd9f verify correct offset in TOK_GETCURINSTTYPE
git-svn-id: https://svn.code.sf.net/p/nsis/code/NSIS/trunk@5424 212acab6-be3b-0410-9dea-997c60f758d6
2007-12-21 22:25:36 +00:00
kichik
0f9d87a2c4 more for bug #1851365
git-svn-id: https://svn.code.sf.net/p/nsis/code/NSIS/trunk@5407 212acab6-be3b-0410-9dea-997c60f758d6
2007-12-20 21:39:56 +00:00
kichik
4690383071 fixed bug #1851365 - mac os x leopard build and run fails - endian issues
git-svn-id: https://svn.code.sf.net/p/nsis/code/NSIS/trunk@5398 212acab6-be3b-0410-9dea-997c60f758d6
2007-12-15 15:28:38 +00:00
kichik
916d3ea3a2 fixed bug #1851273 - relative path Delete doesn't work
git-svn-id: https://svn.code.sf.net/p/nsis/code/NSIS/trunk@5395 212acab6-be3b-0410-9dea-997c60f758d6
2007-12-15 12:24:07 +00:00
kichik
668fe450a4 fixed bug #1841573 - RTL components & instfiles page
WS_EX_LAYOUTRTL can be used for individual controls

git-svn-id: https://svn.code.sf.net/p/nsis/code/NSIS/trunk@5387 212acab6-be3b-0410-9dea-997c60f758d6
2007-11-30 09:54:13 +00:00
kichik
63d000e9c5 implemented RFE #1686589 and fixed bug #1701051 - improve warning for backslash line end in comment
git-svn-id: https://svn.code.sf.net/p/nsis/code/NSIS/trunk@5380 212acab6-be3b-0410-9dea-997c60f758d6
2007-11-18 19:19:55 +00:00
kichik
fb217c5b5c declare real calc_percent()'s code just once
git-svn-id: https://svn.code.sf.net/p/nsis/code/NSIS/trunk@5355 212acab6-be3b-0410-9dea-997c60f758d6
2007-11-09 15:30:08 +00:00
kichik
0c11506eb5 only accept two parameters to Var if the first one is /GLOBAL
git-svn-id: https://svn.code.sf.net/p/nsis/code/NSIS/trunk@5316 212acab6-be3b-0410-9dea-997c60f758d6
2007-10-05 09:01:06 +00:00
kichik
50b9472841 verification dialog is now never used hidden, so it can show itself using WS_VISIBLE
git-svn-id: https://svn.code.sf.net/p/nsis/code/NSIS/trunk@5314 212acab6-be3b-0410-9dea-997c60f758d6
2007-10-03 22:08:37 +00:00
kichik
32854c2021 fixed a bug that where __ensuredata processed window messages using MessageLoop.
this could cause synchronization issues when data is decompressed in a page's leave function and the user clicks the next button twice really fast or on a slow computer.
WM_COMMAND would be sent twice and so DialogProc could execute the leave function while the installation thread is running causing interpreter havoc.

for more details:
http://forums.winamp.com/showthread.php?s=&threadid=274333

as always, a few size optimizations were thrown in the loop and the fix actually makes the code smaller


git-svn-id: https://svn.code.sf.net/p/nsis/code/NSIS/trunk@5313 212acab6-be3b-0410-9dea-997c60f758d6
2007-10-03 22:07:16 +00:00
kichik
9915194e85 more error handling and endianity fixes
git-svn-id: https://svn.code.sf.net/p/nsis/code/NSIS/trunk@5311 212acab6-be3b-0410-9dea-997c60f758d6
2007-10-03 18:27:37 +00:00
kichik
ef5e8a1f70 load default icon from the stub if the user didn't specify a different icon
git-svn-id: https://svn.code.sf.net/p/nsis/code/NSIS/trunk@5310 212acab6-be3b-0410-9dea-997c60f758d6
2007-10-03 18:25:00 +00:00
kichik
2adef603c7 added newline at end of file
git-svn-id: https://svn.code.sf.net/p/nsis/code/NSIS/trunk@5309 212acab6-be3b-0410-9dea-997c60f758d6
2007-10-03 18:03:10 +00:00
kichik
c533664d55 fixed some obvious big-endian failures, but there might be more
git-svn-id: https://svn.code.sf.net/p/nsis/code/NSIS/trunk@5308 212acab6-be3b-0410-9dea-997c60f758d6
2007-10-03 17:52:56 +00:00
kichik
be36b69b03 added support for mismatching installer and uninstaller icons
git-svn-id: https://svn.code.sf.net/p/nsis/code/NSIS/trunk@5307 212acab6-be3b-0410-9dea-997c60f758d6
2007-10-03 17:37:56 +00:00
kichik
a9cf8ee77d fixed GetResourceOffsetA's return type
git-svn-id: https://svn.code.sf.net/p/nsis/code/NSIS/trunk@5306 212acab6-be3b-0410-9dea-997c60f758d6
2007-10-03 17:04:08 +00:00
kichik
36683c9f87 added GetResourceOffsetA/W()
git-svn-id: https://svn.code.sf.net/p/nsis/code/NSIS/trunk@5305 212acab6-be3b-0410-9dea-997c60f758d6
2007-10-03 17:01:19 +00:00
kichik
cc72c11f4f moved icon related functions to icon.cpp
git-svn-id: https://svn.code.sf.net/p/nsis/code/NSIS/trunk@5304 212acab6-be3b-0410-9dea-997c60f758d6
2007-10-03 13:31:56 +00:00
kichik
31a9a49502 size optimization - better values for status_update
git-svn-id: https://svn.code.sf.net/p/nsis/code/NSIS/trunk@5280 212acab6-be3b-0410-9dea-997c60f758d6
2007-09-21 18:20:12 +00:00
kichik
266267ba61 fixed plug-in system's SetDetailsPrint usage
git-svn-id: https://svn.code.sf.net/p/nsis/code/NSIS/trunk@5277 212acab6-be3b-0410-9dea-997c60f758d6
2007-09-18 22:02:44 +00:00
kichik
2f4d9ad346 missing null terminator
git-svn-id: https://svn.code.sf.net/p/nsis/code/NSIS/trunk@5271 212acab6-be3b-0410-9dea-997c60f758d6
2007-09-08 21:01:13 +00:00
kichik
754fe7bc49 added SetRegView lastused
git-svn-id: https://svn.code.sf.net/p/nsis/code/NSIS/trunk@5269 212acab6-be3b-0410-9dea-997c60f758d6
2007-09-08 17:27:28 +00:00
kichik
b0978fc844 move SetDetailsPrint flag to g_exec_flag and added a lastused capability to EW_SETFLAG
git-svn-id: https://svn.code.sf.net/p/nsis/code/NSIS/trunk@5268 212acab6-be3b-0410-9dea-997c60f758d6
2007-09-08 17:20:11 +00:00
kichik
e2b948ae02 tabs to spaces and some other minor clean-ups
git-svn-id: https://svn.code.sf.net/p/nsis/code/NSIS/trunk@5247 212acab6-be3b-0410-9dea-997c60f758d6
2007-08-18 17:15:08 +00:00
joostverburg
842dcbf544 * Use shfolder.dll for CSIDL_COMMON_DOCUMENTS on 95/98 if possible
* Information about API calls for special folders


git-svn-id: https://svn.code.sf.net/p/nsis/code/NSIS/trunk@5245 212acab6-be3b-0410-9dea-997c60f758d6
2007-08-18 12:44:23 +00:00
kichik
35e1cf7b86 better solution - don't old functions and not shfolder but still try to get all user's version from the os (though tests show it will return current user's version anyway)
git-svn-id: https://svn.code.sf.net/p/nsis/code/NSIS/trunk@5238 212acab6-be3b-0410-9dea-997c60f758d6
2007-08-17 16:20:26 +00:00
kichik
b55ecee8cd fixed bug #1766268 - $SMPROGRAMS incorrect on Windows 98
use shfolder.dll only on ME and for all users's $APPDATA for which it was introduced


git-svn-id: https://svn.code.sf.net/p/nsis/code/NSIS/trunk@5237 212acab6-be3b-0410-9dea-997c60f758d6
2007-08-17 16:16:40 +00:00
kichik
68abd8a09e buf1, not buf (patch #1768584)
git-svn-id: https://svn.code.sf.net/p/nsis/code/NSIS/trunk@5234 212acab6-be3b-0410-9dea-997c60f758d6
2007-08-11 17:03:18 +00:00
joostverburg
0865910e56 fixed escaped quotes in macro parameters
git-svn-id: https://svn.code.sf.net/p/nsis/code/NSIS/trunk@5225 212acab6-be3b-0410-9dea-997c60f758d6
2007-08-09 00:19:37 +00:00
pabs3
13989c1965 Prevent FTBFS due to using log_printf3 instead of log_printf2
git-svn-id: https://svn.code.sf.net/p/nsis/code/NSIS/trunk@5220 212acab6-be3b-0410-9dea-997c60f758d6
2007-07-27 00:55:47 +00:00
kichik
7af66a4a9c a bit more logging
git-svn-id: https://svn.code.sf.net/p/nsis/code/NSIS/trunk@5219 212acab6-be3b-0410-9dea-997c60f758d6
2007-07-24 19:06:34 +00:00
kichik
b23a7560ee fixed bug #1758873 - do not link to stdc++ when using aCC
git-svn-id: https://svn.code.sf.net/p/nsis/code/NSIS/trunk@5218 212acab6-be3b-0410-9dea-997c60f758d6
2007-07-23 18:59:35 +00:00
kichik
8e716ed458 applied patch #1758863 - Patch for building on GCC and aCC
git-svn-id: https://svn.code.sf.net/p/nsis/code/NSIS/trunk@5217 212acab6-be3b-0410-9dea-997c60f758d6
2007-07-23 18:43:07 +00:00
kichik
8e1b521859 real implementation for IsValidCodePage
git-svn-id: https://svn.code.sf.net/p/nsis/code/NSIS/trunk@5211 212acab6-be3b-0410-9dea-997c60f758d6
2007-07-18 19:26:16 +00:00
kichik
6133677dba get rid of some #ifdef _WIN32
git-svn-id: https://svn.code.sf.net/p/nsis/code/NSIS/trunk@5210 212acab6-be3b-0410-9dea-997c60f758d6
2007-07-18 19:21:38 +00:00
kichik
30d04c642b added HWND
git-svn-id: https://svn.code.sf.net/p/nsis/code/NSIS/trunk@5209 212acab6-be3b-0410-9dea-997c60f758d6
2007-07-18 19:21:30 +00:00
kichik
3e9377d5b2 moved non-win32 CharNextExA implementation to util.cpp
git-svn-id: https://svn.code.sf.net/p/nsis/code/NSIS/trunk@5208 212acab6-be3b-0410-9dea-997c60f758d6
2007-07-18 19:18:00 +00:00
kichik
d56004079e fixed bug #1755148 - hpux build linkage specification in main
git-svn-id: https://svn.code.sf.net/p/nsis/code/NSIS/trunk@5206 212acab6-be3b-0410-9dea-997c60f758d6
2007-07-17 16:45:13 +00:00
kichik
9841c1ec97 fixed bug #1753063 - CVS test failure on hppa
git-svn-id: https://svn.code.sf.net/p/nsis/code/NSIS/trunk@5205 212acab6-be3b-0410-9dea-997c60f758d6
2007-07-16 18:28:18 +00:00