Filled in some missing pieces in html for core upgrades. Looked mostly good on both Cyr and Jacob's accounts.
I had a few questions about differences that were added from DND5e, they are as follows:
less\original\npc.less
line 34 - is the "li" before .creature-type necessary, not in dnd5e
module\item\entity.js
line 685 - dnd is game.user._id, we have game.user.data._id
module\pixi\ability-template.js
line 22- dnd is game.user._id, we have game.user.data._id
templates\chat\item-card.html
line 1- dnd has actor._id, we have actor.data._id
Things unfinished:
- Migration
- The update adds new sections to the class sheet to allow some light customisation, this hasn't been included, but could be extended for the sake of dynamic classes with automatic class features and more
- The French
- The packs have not yet been updated, meaning due to the addition of a progression field to the class item, classes now don't set force or tech points
- I updated the function calls in starships, but I didn't update it very thoroughly, it'll need checking
- I only did a little testing
- There has since been updates to DND5e that hasn't made it to release that patch bugs, those should be implemented
Things changed from base 5e:
- Short rests and long rests were merged into one function, this needed some rewrites to account for force and tech points, and for printing the correct message
Extra Comments:
- Unfinished code exists for automatic spell scrolls, this could be extended for single use force or tech powers
- Weapon proficiencies probably need revising
- Elven accuracy, halfling lucky, and reliable talent are present in the roll logic, this probably needs revising for sw5e
- SW5e has a variant rule that permits force powers of any alignment to use either charisma or wisdom, that could be implemented
- SW5e's version of gritty realism, [Longer Rests](https://sw5e.com/rules/variantRules/Longer%20Rests) differs from base dnd, this could be implemented
- Extra ideas I've had while looking through the code can be found in Todos next to the ideas relevant context
