Filled in some missing pieces in html for core upgrades. Looked mostly good on both Cyr and Jacob's accounts.
I had a few questions about differences that were added from DND5e, they are as follows:
less\original\npc.less
line 34 - is the "li" before .creature-type necessary, not in dnd5e
module\item\entity.js
line 685 - dnd is game.user._id, we have game.user.data._id
module\pixi\ability-template.js
line 22- dnd is game.user._id, we have game.user.data._id
templates\chat\item-card.html
line 1- dnd has actor._id, we have actor.data._id
Things unfinished:
- Migration
- The update adds new sections to the class sheet to allow some light customisation, this hasn't been included, but could be extended for the sake of dynamic classes with automatic class features and more
- The French
- The packs have not yet been updated, meaning due to the addition of a progression field to the class item, classes now don't set force or tech points
- I updated the function calls in starships, but I didn't update it very thoroughly, it'll need checking
- I only did a little testing
- There has since been updates to DND5e that hasn't made it to release that patch bugs, those should be implemented
Things changed from base 5e:
- Short rests and long rests were merged into one function, this needed some rewrites to account for force and tech points, and for printing the correct message
Extra Comments:
- Unfinished code exists for automatic spell scrolls, this could be extended for single use force or tech powers
- Weapon proficiencies probably need revising
- Elven accuracy, halfling lucky, and reliable talent are present in the roll logic, this probably needs revising for sw5e
- SW5e has a variant rule that permits force powers of any alignment to use either charisma or wisdom, that could be implemented
- SW5e's version of gritty realism, [Longer Rests](https://sw5e.com/rules/variantRules/Longer%20Rests) differs from base dnd, this could be implemented
- Extra ideas I've had while looking through the code can be found in Todos next to the ideas relevant context
Update defaults to null from 0 to allow descriptor of fields to show
Noted by Bacalla:
8206774843
I followed suit from the HP model, need to test to make sure this doesn't break anything. All the code appears to default to 0 if it is null.
- Reverted UUID for 000 Series Protocol Droid.
- Updated NPC migration to check for dataVersion flag and shortcut out
- Attempted to add Item migration like NPC migration to fix power concentration and prerequisites, but it fails on compendium pull
Changed to use newer createEmbeddedEntity (createOwnedItem will be deprecated in 0.8.x) and push the entire newPowers array at the same time. Still saying createEmbeddedEntity doesn't exist on actor.
Adding flag for dataVersion control
** added shell of migration.js for updating NPC Data. This is only being pushed for visibility by people other than me and is by no means done or tested and probably very broken.
Line 159 commented out to keep from running broken function. Uncomment for testing.
Broken _updateNPCData from lines 242 to 289
I think this will migrate every value over to have 1000 casts, which will then get reset to the lower of the value or character max once the actor is loaded. Essentially pushing a long rest for power casting limits upon migration.
System main update to be inline with dnd5e 1.1.1
Added active effects to as many sheets as I thought applicable. Please check loot, I made an attempt but it may be broken
All .less .css and actor .html updates were made to the old actors. New actors may be broken with this update
removed templates\actors\oldActor\parts\actor-effects.html for newer templates\actors\parts\active-effects.html
removed module\apps\cast-dialog, templates\apps\cast-cast.html, and templates\items\cast.html. I do not think they are used, I think they were deprecated when powers were treated as items, if not we can add them back in.
**NOTE** REQUIRES Foundry 0.7.6
Updated to 0.98 core for 0.7.x compatability (untested)
Class Skills are pulling in automatically on class item drop to character sheet.
TODO: Expand automated skill drop for Archetypes
KNOWN ISSUE: init.value is being converted to a string causing some NaN errors on the html. Initiative was changed to a number instead of a string in 0.98 likely some place is assuming it is still a string. I had to use Number() on the value because it was forcing other vales to be a string because the value is "". Maybe someone can fix this
